DM-39760: Make NoDimensionsTask test utility consistent about storage classes. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 82.59% 82.54% -0.06%
==========================================
Files 66 66
Lines 7143 7148 +5
Branches 1393 1394 +1
==========================================
Hits 5900 5900
- Misses 996 1001 +5
Partials 247 247
☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-39760
branch
from
e6bc020
to
c6e640c
Compare
timj
approved these changes
Jun 22, 2023
|
|
||
| class NoDimensionsTestConfig(PipelineTaskConfig, pipelineConnections=NoDimensionsTestConnections): | ||
| """Configuration for `NoDimensionTestTask`.""" | ||
|
|
||
| key = Field[str](doc="String key for the dict entry the task sets.", default="one") | ||
| value = Field[int](doc="Integer value for the dict entry the task sets.", default=1) | ||
| outputSC = Field[str](doc="Output storage class requested", default="dict") | ||
| outputSC = Field[str](doc="Output Python type requested", default="StructuredDataDict") |
There was a problem hiding this comment.
The doc string is now wrong isn't it?
There was a problem hiding this comment.
Ah, yup, my first attempt at fixing this was just changing the docs, and then I forgot to revert that when I changed course.
The config option provided by this task to change its output storage class actually only change the Python type returned, making that type inconsistent with the storage class it declared in its connections. This means we've long been testing essentially the wrong behavior. This also switches the default for outputSC from 'dict' to 'StructuredDataDict', since it's supposed to be a storage class name, not a pytype. This wasn't causing trouble, but it was very confusing.
TallJimbo
force-pushed
the
tickets/DM-39760
branch
from
c6e640c
to
cf2b212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config option provided by this task to change its output storage class actually only changes the Python type returned, making that type inconsistent with the storage class it declared in its connections. This means we've long been testing essentially the wrong behavior.
This also switches the default for outputSC from 'dict' to 'StructuredDataDict', since it's supposed to be a storage class name, not a pytype. This wasn't causing trouble, but it was very confusing.
Checklist
added a release note for user-visible changes to(I'm considering this not-user-visible, I think?)doc/changes